Fix assetIds decoding: return 400 instead of 500 on malformed JSON#511
Merged
s-heppner merged 1 commit intoMay 8, 2026
Merged
Conversation
…g KeyError as 500
s-heppner
approved these changes
May 8, 2026
This was referenced May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502
Changes
asset_dict["name"]/asset_dict["value"]in atry/except KeyErrorand raiseBadRequestwith a descriptive message — client input validation errors must return 4xx, not 5xxtest_malformed_asset_id_missing_field_returns_400unit test using Werkzeug test client